Introduce new op types GPI, GPI2 and AAMS
#1329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-alec
force-pushed
the
feature/newoptypes
branch
2 times, most recently
from
481bb61
to
15c6455
Compare
More tests.
cqc-alec
force-pushed
the
feature/newoptypes
branch
from
15c6455
to
677b978
Compare
yao-cqc
reviewed
Apr 9, 2024
pytket/binders/circuit/main.cpp
Outdated
Comment on lines
200
to
210
| ":math:`(\\theta, \\phi_0, \\phi_1) \\mapsto \\left[ " | ||
| "\\begin{array}{cccc} \\cos\\frac{\\pi\\theta}{2} & 0 & 0 & " | ||
| "-ie^{-i\\pi{\\phi_0+\\phi_1}}\\sin\\frac{\\pi\\theta}{2} \\\\ " | ||
| "0 & " | ||
| "\\cos\\frac{\\pi\\theta}{2} & " | ||
| "-ie^{i\\pi{\\phi_0-\\phi_1}}\\sin\\frac{\\pi\\theta}{2} & 0 \\\\ 0 " | ||
| "& " | ||
| "-ie^{i\\pi{\\phi_0-\\phi_1}}\\sin\\frac{\\pi\\theta}{2} & " | ||
| "\\cos\\frac{\\pi\\theta}{2} & 0 \\\\ " | ||
| "-ie^{i\\pi{\\phi_0+\\phi_1}}\\sin\\frac{\\pi\\theta}{2} & 0 & 0 & " | ||
| "\\cos\\frac{\\pi\\theta}{2} \\end{array} \\right]`") |
There was a problem hiding this comment.
missing parentheses in the exponents
e.g.
-ie^{-i\\pi{\\phi_0+\\phi_1}}\\sin\\frac{\\pi\\theta}{2} should be
-ie^{-i\\pi(\\phi_0+\\phi_1)}\\sin\\frac{\\pi\\theta}{2}
same problem in OpType.hpp
also the exponent of the second non-zero entry in the second row should be
i\pi(\phi_1-\phi_0) instead of i\pi(\phi_0-\phi_1)
There was a problem hiding this comment.
Good spot, thanks.
yao-cqc
approved these changes
Apr 10, 2024
|
PR has been merged, but PR status not updated for some reason. |
|
Closing this manually as github problems prevented it from being closed when merged. |
daniel-mills-cqc
pushed a commit
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the IonQ native ops defined here.
Related issues
Closes #1259 .
Checklist